The following document contains the results of PMD 4.3.
Violation | Line |
---|---|
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 34 - 86 |
Parameter 'descendentNode' is not assigned and could be declared final | 42 |
Parameter 'slingResourceType' is not assigned and could be declared final | 42 |
Local variable 'simpleDescendentNode' could be declared final | 43 |
Parameter 'resourcePath' is not assigned and could be declared final | 47 |
Parameter 'resourceResolver' is not assigned and could be declared final | 47 |
Parameter 'node' is not assigned and could be declared final | 59 |
Avoid using Literals in Conditional Statements | 61 |
Local variable 'simpleNode' could be declared final | 62 |
Parameter 'slingRequest' is not assigned and could be declared final | 69 |
Local variable 'requestPathInfo' could be declared final | 70 |
Local variable 'selectors' could be declared final | 71 |
Parameter 'selector' is not assigned and could be declared final | 78 |
Parameter 'slingRequest' is not assigned and could be declared final | 78 |
Local variable 'selectors' could be declared final | 80 |
Violation | Line |
---|---|
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 17 - 142 |
Avoid unused private fields such as 'LOG'. | 21 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 24 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 26 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 27 |
Avoid reassigning parameters such as 'urlPath' | 32 |
Avoid reassigning parameters such as 'urlPath' | 32 |
Avoid reassigning parameters such as 'urlPath' | 32 |
Avoid reassigning parameters such as 'urlPath' | 32 |
Avoid using Literals in Conditional Statements | 33 |
This call to String.startsWith can be rewritten using String.charAt(0) | 36 |
Local variable 'extPlusSuffix' could be declared final | 42 |
Assigning an Object to null is a code smell. Consider refactoring. | 53 |
Assigning an Object to null is a code smell. Consider refactoring. | 73 |
Avoid using Literals in Conditional Statements | 76 |
Assigning an Object to null is a code smell. Consider refactoring. | 77 |
Assigning an Object to null is a code smell. Consider refactoring. | 85 |
Assigning an Object to null is a code smell. Consider refactoring. | 87 |
Assigning an Object to null is a code smell. Consider refactoring. | 88 |
Returning 'selectors' may expose an internal array. | 113 |
Parameter 'resource' is not assigned and could be declared final | 134 |
Parameter 'path' is not assigned and could be declared final | 138 |
Violation | Line |
---|---|
Document empty method | 22 - 23 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 22 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 22 |
Document empty method | 26 - 27 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 26 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 26 |
Document empty method | 30 - 31 |
Document empty method | 34 - 35 |
Local variable 'pathInfo' could be declared final | 39 |
The String literal "/a/b" appears 8 times in this file; the first occurrence is on line 39 | 39 |
JUnit assertions should include a message | 40 |
JUnit assertions should include a message | 41 |
JUnit assertions should include a message | 42 |
JUnit assertions should include a message | 43 |
JUnit assertions should include a message | 44 |
Local variable 'pathInfo' could be declared final | 49 |
JUnit assertions should include a message | 50 |
JUnit assertions should include a message | 51 |
JUnit assertions should include a message | 52 |
JUnit assertions should include a message | 53 |
The String literal "html" appears 6 times in this file; the first occurrence is on line 53 | 53 |
JUnit assertions should include a message | 54 |
Local variable 'pathInfo' could be declared final | 59 |
JUnit assertions should include a message | 60 |
JUnit assertions should include a message | 61 |
JUnit assertions should include a message | 62 |
JUnit assertions should include a message | 63 |
JUnit assertions should include a message | 64 |
JUnit assertions should include a message | 65 |
JUnit assertions should include a message | 66 |
Local variable 'pathInfo' could be declared final | 71 |
JUnit assertions should include a message | 72 |
JUnit assertions should include a message | 73 |
JUnit assertions should include a message | 74 |
JUnit assertions should include a message | 75 |
JUnit assertions should include a message | 76 |
JUnit assertions should include a message | 77 |
JUnit assertions should include a message | 78 |
Local variable 'pathInfo' could be declared final | 83 |
JUnit assertions should include a message | 84 |
JUnit assertions should include a message | 85 |
JUnit assertions should include a message | 86 |
JUnit assertions should include a message | 87 |
JUnit assertions should include a message | 88 |
JUnit assertions should include a message | 89 |
Local variable 'pathInfo' could be declared final | 94 |
JUnit assertions should include a message | 95 |
JUnit assertions should include a message | 96 |
JUnit assertions should include a message | 97 |
JUnit assertions should include a message | 98 |
JUnit assertions should include a message | 99 |
JUnit assertions should include a message | 100 |
Local variable 'pathInfo' could be declared final | 105 |
JUnit assertions should include a message | 106 |
JUnit assertions should include a message | 107 |
JUnit assertions should include a message | 108 |
JUnit assertions should include a message | 109 |
JUnit assertions should include a message | 110 |